Blend space editor: Use correct name in events, and clean all states#119070
Merged
Conversation
godotengine#110369 changed the names from itos(index), to custom names however the "animation_node_removed" signal was not updated to reflect that change. Also its safer to clear all the state when removing, rather than just the name.
AThousandShips
changed the title
Contributor
|
While this does fix the crash, undoing deleting Before deleting: After deleting: After deleting & undo: |
Contributor
Author
Could you try testing this with #119069 applied on top? IIRC it fixed some weird undo behaviour when I tried it, so it might resolve that too. |
Member
|
@Ryan-000 If those two PRs are related, it might be helpful to merge them into a single PR. |
Contributor
|
Indeed, that PR applied on top of this one makes it work correctly |
BlueCube3310
approved these changes
May 10, 2026
Contributor
BlueCube3310
left a comment
BlueCube3310
left a comment
There was a problem hiding this comment.
Looks good to me, the crashing is fixed and the code changes make sense
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #119029
Resolves #118982
#110369 changed the names from
itos(index), to custom names however theanimation_node_removedsignal was not updated to reflect that change.Also, it's safer to clear all the state when removing, rather than just the name.